Skip to content

♻️ rerouted update projects networks via dynamic-scheduler #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 16, 2024
Merged

♻️ rerouted update projects networks via dynamic-scheduler #6945

merged 12 commits into from
Dec 16, 2024

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 11, 2024 •
edited
Loading

What do these changes do?

Rerouted update project networks command via dynamic-scheduler.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 11, 2024
@GitHK GitHK added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:dynamic-scheduler labels Dec 11, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 11, 2024
@codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.14%. Comparing base (95d208b) to head (8b7d4c9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6945      +/-   ##
==========================================
+ Coverage   88.11%   88.14%   +0.03%     
==========================================
  Files        1592     1585       -7     
  Lines       62337    62164     -173     
  Branches     2012     2013       +1     
==========================================
- Hits        54928    54796     -132     
+ Misses       7074     7032      -42     
- Partials      335      336       +1
Flag Coverage Δ
integrationtests 65.00% <33.33%> (+0.02%) ⬆️
unittests 86.35% <85.29%> (+0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.24% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.05% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.52% <0.00%> (-0.12%) ⬇️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.38% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.03% <100.00%> (+0.04%) ⬆️
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.58% <ø> (+0.26%) ⬆️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.74% <93.33%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d208b...8b7d4c9. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review December 12, 2024 15:32
pcrespov
pcrespov reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as in the other Prs #6943 (review)

pcrespov
pcrespov approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the explanation.

@GitHK GitHK enabled auto-merge (squash) December 16, 2024 14:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit e391377 into ITISFoundation:master Dec 16, 2024
89 of 92 checks passed
@GitHK GitHK deleted the pr-osparc-reroute-update-projects-networks branch December 16, 2024 16:24
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2025
Closed
14 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@GitHK GitHK

Labels

a:dynamic-scheduler a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

redirect update_projects_networks call via dynamic-scheduler

4 participants

@GitHK @pcrespov @sanderegg @matusdrobuliak66